[webkit-reviews] review denied: [Bug 55453] Pass preferred language information down to font fallback logic : [Attachment 84584] Fix indentation pointed out by Tony.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Takayoshi Kochi
<kochi at chromium.org>'s request for review:
Bug 55453: Pass preferred language information down to font fallback logic
https://bugs.webkit.org/show_bug.cgi?id=55453

Attachment 84584: Fix indentation pointed out by Tony.
https://bugs.webkit.org/attachment.cgi?id=84584&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84584&action=review

r- because this patch is missing a ChangeLog entry.  Also, shouldn't there be a
LayoutTest?

> WebKit/chromium/public/gtk/WebFontInfo.h:53
> -    WEBKIT_API static WebCString familyForChars(const WebUChar* characters,
size_t numCharacters);
> +    WEBKIT_API static WebCString familyForChars(const WebUChar* characters,
size_t numCharacters, const char* preferredLocale = 0);

Please file a bug about making |preferredLocale| not have a default param after
the chromium side is landed and rolled in.