[webkit-reviews] review granted: [Bug 54710] [chromium] Create a LayerChromium layerTreeAsText. Add HUD to LayerRendererChromium that draws compositor FPS and, optionally, the layer tree. : [Attachment 84653] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 54710: [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally, the layer
tree.
https://bugs.webkit.org/show_bug.cgi?id=54710

Attachment 84653: Patch
https://bugs.webkit.org/attachment.cgi?id=84653&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84653&action=review

Looks fine.  Two very minor nits - I'm fine with landing as is or going one
more.

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:114
> +void CCHeadsUpDisplay::drawHudContents(GraphicsContext* ctx, const IntSize&
hudSize)
> +{
> +    FontDescription medFontDesc;

nit: WK prefers full words (context, medium) over abbr.

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.h:60
> +    CCHeadsUpDisplay(LayerRendererChromium* owner);

nit: still needs explicit