[webkit-reviews] review requested: [Bug 54392] [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style : [Attachment 84649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 16:21:03 PST 2011


Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 54392: [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter
style
https://bugs.webkit.org/show_bug.cgi?id=54392

Attachment 84649: Patch
https://bugs.webkit.org/attachment.cgi?id=84649&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Functions of RenderThemeEfl.cpp have efl coding style. But, WebCore's functions
should adhere WebKit coding style.
So, I modify the efl style parameter as below,

- EvasObject* o -> EvasObject* object
- ThemePartCacheEntry* ce -> ThemePartCacheEntry* entry
- PaintInfo& i -> PaintInfo& info
- RenderObject* o -> RenderObject* object


More information about the webkit-reviews mailing list