[webkit-reviews] review denied: [Bug 49829] WebKit2: Add WKViewRef API for executing edit commands : [Attachment 84645] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Jeff Miller <jeffm at apple.com>'s
request for review:
Bug 49829: WebKit2: Add WKViewRef API for executing edit commands
https://bugs.webkit.org/show_bug.cgi?id=49829

Attachment 84645: Patch
https://bugs.webkit.org/attachment.cgi?id=84645&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84645&action=review

> Source/WebKit2/UIProcess/API/C/win/WKView.h:54
> +    Valid command name strings include:

Maybe this could mention that it accepts all WebCore editing commands?

> Source/WebKit2/UIProcess/API/C/win/WKView.h:64
> +WK_EXPORT void WKViewExecuteCommand(WKViewRef view, WKStringRef command);

It's probably simpler if this takes a const char* since edit commands are all
ASCII and that would make it easier for API clients.