[webkit-reviews] review granted: [Bug 55694] NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers : [Attachment 84622] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 55694: NRWT: AttributeError: TestRunner2 instance has no attribute
'_cancel_workers
https://bugs.webkit.org/show_bug.cgi?id=55694

Attachment 84622: Patch
https://bugs.webkit.org/attachment.cgi?id=84622&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84622&action=review

> Tools/ChangeLog:12
> +	   - Fix ordering of returned arguments from TestRunner2._run_tests
> +	     (interrupted and keyboard_interrupted were reversed)

This is one of the reasons why I prefer classes to tuples, although I guess it
wouldn't have helped in this case (constructing the return object).