[webkit-reviews] review granted: [Bug 55702] Scrubbing <video> with HTTP Live Stream resizes element to 0x0 : [Attachment 84620] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 55702: Scrubbing <video> with HTTP Live Stream resizes element to 0x0
https://bugs.webkit.org/show_bug.cgi?id=55702

Attachment 84620: Patch
https://bugs.webkit.org/attachment.cgi?id=84620&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review

> Source/WebCore/ChangeLog:9
> +	   a HTTP Live Stream.	So we will cache the last valid value returned
by QTKit

"an HTTP Live Stream"?

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211
> +    FloatSize m_cachedNaturalSize;

You could make this mutable.

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232
> +    , m_cachedNaturalSize(FloatSize())

No need to initialize; FloatSize has its own ctor.