[webkit-reviews] review denied: [Bug 55704] Not all plugins should be opt out of 32-bit NX : [Attachment 84619] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 3 13:59:35 PST 2011
Anders Carlsson <andersca at apple.com> has denied Damian Kaleta
<dkaleta at apple.com>'s request for review:
Bug 55704: Not all plugins should be opt out of 32-bit NX
https://bugs.webkit.org/show_bug.cgi?id=55704
Attachment 84619: Patch
https://bugs.webkit.org/attachment.cgi?id=84619&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84619&action=review
> WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:222
> +bool PluginProcessProxy::pluginNeedsExecutableHeap(const
PluginInfoStore::Plugin& pluginInfo) const
This doesn't need to be a member function of PluginProcessProxy, it can just be
a static free function (and I'd put it above the call site.
More information about the webkit-reviews
mailing list