[webkit-reviews] review denied: [Bug 55644] [fileapi] Add URI resolution support to WorkerContext : [Attachment 84604] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Adam Klein <adamk at chromium.org>'s
request for review:
Bug 55644: [fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Attachment 84604: Patch
https://bugs.webkit.org/attachment.cgi?id=84604&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84604&action=review

> Source/WebCore/ChangeLog:9
> +	   in the WebKit Chromium builds.

Why are are adding more stuff here if none of it is testable? (I thought I saw
some tests for the file system in workers but maybe not.)

If they aren't testable, can we fix that before adding more here.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:77
> +    openFileSystemHelper(context, type, callbacks, synchronous, 0, false);

That last parameter should be an enum instead of a bool to make the call sites
more readable.