[webkit-reviews] review granted: [Bug 55017] SVGImage causes MainResourceLoader leaks : [Attachment 84534] Fix sandbox issue

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Xianzhu Wang
<wangxianzhu at google.com>'s request for review:
Bug 55017: SVGImage causes MainResourceLoader leaks
https://bugs.webkit.org/show_bug.cgi?id=55017

Attachment 84534: Fix sandbox issue
https://bugs.webkit.org/attachment.cgi?id=84534&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84534&action=review

I continue to like this patch because it removes cruft from the SVGImage bootup
code.  Please give Alexey a chance to suggest an approach for additional
testing before landing.  Thanks!

> LayoutTests/fast/images/svg-image-leak-loader.html:6
> +  layoutTestController.dumpAsText();
> +  layoutTestController.waitUntilDone();

We usually use four-space indent in tests, but it doesn't really matter.

> LayoutTests/fast/images/resources/load-script.html:3
> +<script src="XXXXX.js"></script>

I might have called this "does-not-exist.js" so a future reader doesn't need to
wonder what XXXXX means.