[webkit-reviews] review denied: [Bug 52877] Detach Geolocation from Frame when Page destroyed. : [Attachment 84575] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 52877: Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Attachment 84575: Patch
https://bugs.webkit.org/attachment.cgi?id=84575&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think the approach here for iframe reparenting is incorrect.

This patch actually adds code to specifically break geolocation working after
iframe reparenting (it should in fact continue working) and also adds a test
that verifies the borkage and documents it as "test passes".
I realize there is another bug filed for iframe reparenting and geolocation
scenario. It is better to actually fix the issue in that bug, rather then
solidify the exactly opposite behavior (and test for it).  For anybody who will
look at the code and test in the future, this will be highly confusing as to
what behavior we actually tried to achieve.
I think we should remove "iframe reparenting" part of this patch. Whatever we
have now is not worse then this, and there is a specific bug to fix iframe
reparenting.