[webkit-reviews] review granted: [Bug 55653] Moved all variable object storage inline -- upping the object size limit to 1K : [Attachment 84527] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 3 10:48:25 PST 2011
Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 55653: Moved all variable object storage inline -- upping the object size
limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
Attachment 84527: Patch
https://bugs.webkit.org/attachment.cgi?id=84527&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84527&action=review
Please make sure to fix the Qt and Windows builds. Both are failing on the EWS
bots.
> Source/WebCore/bindings/js/JSDOMGlobalObject.h:81
> + Event* m_evt;
Can this be named m_event instead? Why abbreviate event to "evt".
More information about the webkit-reviews
mailing list