[webkit-reviews] review granted: [Bug 55464] Web Inspector: extract all code that depends on source mapping from SourceFrame : [Attachment 84221] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55464: Web Inspector: extract all code that depends on source mapping from
SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=55464

Attachment 84221: Patch.
https://bugs.webkit.org/attachment.cgi?id=84221&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84221&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1072
> +	       var delegate = new
WebInspector.SourceFrameDelegateForResourcesPanel(this._script.resource);

This looks very odd. The delegate should be called by the SourceFrame. Common
functionality of the delegates could either be provided by their superclass or
moved into an utility function.