[webkit-reviews] review granted: [Bug 55554] Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h : [Attachment 84517] Fixed per Darin's comment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 3 08:21:32 PST 2011
Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 55554: Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554
Attachment 84517: Fixed per Darin's comment
https://bugs.webkit.org/attachment.cgi?id=84517&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84517&action=review
> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:416
> + setRegisters(registerFile.start(), PassOwnArrayPtr<Register>(), 0);
In the future I think we should make nullptr work for these cases. We can’t
make 0 work without allowing arbitrary pointers, but we can make nullptr work,
which is much more beautiful than this. Nothing to do with this patch, but I
wanted Ryosuke to know.
More information about the webkit-reviews
mailing list