[webkit-reviews] review requested: [Bug 55482] Web Inspector: introduce protocol test for RuntimeAgent. : [Attachment 84538] [patch] second iteration.

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 55482: Web Inspector: introduce protocol test for RuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=55482

Attachment 84538: [patch] second iteration.
https://bugs.webkit.org/attachment.cgi?id=84538&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
> Given that this is a protocol test, it would be nice to dump both: protocol
> request and response:
> {
>    request : {
>    }
>    response : {
>    }
> }

done.

> > LayoutTests/inspector/protocol/runtime-agent-expected.txt:20
> > +	     injectedScriptId : 1
> 
> This can become the source of flake. However, if it does not, lets leave it
> like this.
> Btw, addObject allows printing types of members with given names instead of
> their values.
> 
> > LayoutTests/inspector/protocol/runtime-agent-expected.txt:21
> > +	     id : 1

done.


> > LayoutTests/inspector/protocol/runtime-agent-expected.txt:34
> > +	 $ : true
> 
> Two problems here:
> 1) it does not list getElementBy*
> 2) We should really send these in array of strings. That was we would be able

> to send "__proto__" suggestion. Should be a separate patch though.
> 
> Also, it is worth sending getCompletions('windo') and passing 'false' in
> includeCommandLineAPI.

doesn't work as expected. No idea what is the reason.