[webkit-reviews] review denied: [Bug 54795] [Chromium] Autocomplete suggestion extends out of window (and onto second monitor) : [Attachment 84522] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 2 23:23:34 PST 2011


Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 54795: [Chromium] Autocomplete suggestion extends out of window (and onto
second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795

Attachment 84522: Patch
https://bugs.webkit.org/attachment.cgi?id=84522&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84522&action=review

> Source/WebCore/manual-tests/popup-width-restriction-within-screen.html:13
> +   <li> Launch Chrome and maximize the browser window size in the left
screen.</li>

Do not use the specific browser name "Chrome".
This test is helpful for any browsers.

Also, can we provide <select> with very long <option> in advance instead of
depending on input history suggestion feature?	Though it might be not enough
for really large display.

> Source/WebCore/manual-tests/popup-width-restriction-within-screen.html:23
> +   <li> Launch Chrome and maximize the browser window size in the right
screen.</li>

ditto. Do not use "Chrome"


More information about the webkit-reviews mailing list