[webkit-reviews] review denied: [Bug 55494] Rebaseline of a layout test due to antialiasing issue for leopard/snowleopard : [Attachment 84503] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has denied  review:
Bug 55494: Rebaseline of a layout test due to antialiasing issue for
leopard/snowleopard
https://bugs.webkit.org/show_bug.cgi?id=55494

Attachment 84503: Patch
https://bugs.webkit.org/attachment.cgi?id=84503&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
Actually, now that I've looked at the current results
(http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpect
ations=true&showAllRuns=true&tests=media%2Fvideo-layer-crash.html&group=%40ToT%
20-%20chromium.org) and patched this in, I'm not sure I understand this change.


As far as I can tell, the test is currently passing everywhere except on 10.6
(Snow Leopard). The patch currently only adds chromium-mac-leopard baselines,
which won't help with that. I think the correct things to do would be to:
1) Move the current chromium-mac baselines (which are valid for Leopard only)
to chromium-mac-leopard
2) Add new Snow Leopard baselines to chromium-mac
3) Remove the media/video-layer-crash.html lines from test_expectations.txt
(both the MAC and LINUX ones)

Sorry if I'm misunderstanding anything, feel free to ping me in #webkit or on
IM.