[webkit-reviews] review granted: [Bug 55535] NRWT - implement Linux Hardy 64-bit port : [Attachment 84491] update w/ review feedback from tony

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 55535: NRWT - implement Linux Hardy 64-bit port
https://bugs.webkit.org/show_bug.cgi?id=55535

Attachment 84491: update w/ review feedback from tony
https://bugs.webkit.org/attachment.cgi?id=84491&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84491&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py:59
> +	       if port_name.startswith('chromium-linux'):

Can this be == instead of startswith?

> Tools/Scripts/webkitpy/layout_tests/port/google_chrome.py:71
> +	       def architecture(self):
> +		   # Because we're specifying chromium-linux-86 below, we
> +		   # don't really need this line, but it is probably slightly
> +		   # clearer to have it.
> +		   return 'x86'

I find this to be noisy.  I would just remove it.

> Tools/Scripts/webkitpy/layout_tests/port/google_chrome.py:92
> +	   return GoogleChromeLinux64Port(port_name='chromium-linux-x86',
**kwargs)

This might use a comment explaining why it's x86 even though we're linux 64.