[webkit-reviews] review granted: [Bug 55553] When displaying the missing plug-in sheet, pass the 'pluginspage' attribute to the UI process. : [Attachment 84371] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 55553: When displaying the missing plug-in sheet, pass the 'pluginspage'
attribute to the UI process.
https://bugs.webkit.org/show_bug.cgi?id=55553

Attachment 84371: Patch
https://bugs.webkit.org/attachment.cgi?id=84371&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461
> +   
m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->
serviceType(), pluginElement->url(),
pluginElement->getAttribute("pluginspage")));

For better performance, this should be:

    fastGetAttribute(pluginspageAttr);

And that might require exporting another symbol.