[webkit-reviews] review denied: [Bug 55568] [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem : [Attachment 84398] Patch to fix the issue

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 55568: [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
https://bugs.webkit.org/show_bug.cgi?id=55568

Attachment 84398: Patch to fix the issue
https://bugs.webkit.org/attachment.cgi?id=84398&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84398&action=review

We unfortunately still support 4.6. You should #ifdef for now, so that code can
be removed as soon as we release 4.8.

> Source/WebKit/qt/Api/qgraphicswebview.cpp:475
>      connect(d->page, SIGNAL(microFocusChanged()),
> -	       this, SLOT(_q_updateMicroFocus()));
> +	       this, SLOT(updateMicroFocus()));

This could go on a single line. We don't have 80 char limit for WebKit.