[webkit-reviews] review granted: [Bug 55599] r80079 caused incremental Windows builds to fail : [Attachment 84445] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 2 12:43:38 PST 2011
Tony Chang <tony at chromium.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 55599: r80079 caused incremental Windows builds to fail
https://bugs.webkit.org/show_bug.cgi?id=55599
Attachment 84445: Patch
https://bugs.webkit.org/attachment.cgi?id=84445&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84445&action=review
>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-cha
nges.py:24
> + for extension in ['manifest', 'pch', 'res']:
Nit: Using a tuple instead of a list is a bit more efficient.
More information about the webkit-reviews
mailing list