[webkit-reviews] review granted: [Bug 55504] Use of uninitialized value in numeric lt (<) at Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash : [Attachment 84423] Don't try to capture crash logs on platforms that haven't implemented that feature

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 55504: Use of uninitialized value in numeric lt (<) at
Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
https://bugs.webkit.org/show_bug.cgi?id=55504

Attachment 84423: Don't try to capture crash logs on platforms that haven't
implemented that feature
https://bugs.webkit.org/attachment.cgi?id=84423&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84423&action=review

r=me with that fix! Thanks!

> Tools/Scripts/old-run-webkit-tests:1793
> +    return unless $#paths;

"$#paths" returns the last index in the array. So if there is 1 item, the last
index will
be 0, and this might still bail. As you mentioned on IRC, an alternative to
getting the
size of the array is "scalar(@paths)". That seems better.