[webkit-reviews] review granted: [Bug 55572] Check for spaces in names doesn't take into account non-alphanumeric characters : [Attachment 84411] Better patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 2 10:25:59 PST 2011


Eric Seidel <eric at webkit.org> has granted Berend-Jan Wever
<skylined at chromium.org>'s request for review:
Bug 55572: Check for spaces in names doesn't take into account non-alphanumeric
characters
https://bugs.webkit.org/show_bug.cgi?id=55572

Attachment 84411: Better patch
https://bugs.webkit.org/attachment.cgi?id=84411&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm confued.  "B.J. Wever" has a space in it, doesn't it?  What's it matching? 
Is it incorrectly picking up on ly part of your name?

This change looks fine though, but I don't really understand how the old code
failed for you.


More information about the webkit-reviews mailing list