[webkit-reviews] review denied: [Bug 55563] Web Inspector: [Chromium] Landing detailed heap snapshots, part 4 : [Attachment 84392] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 55563: Web Inspector: [Chromium] Landing detailed heap snapshots, part 4
https://bugs.webkit.org/show_bug.cgi?id=55563

Attachment 84392: patch
https://bugs.webkit.org/attachment.cgi?id=84392&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84392&action=review

> Source/WebCore/bindings/v8/ScriptHeapSnapshot.h:62
> +    int getExactRetainedSize(uint64_t nodeId);

exactRetainedSize

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:118
> +    _getSortFields: function(sortColumn, sortAscending)

_sortFields

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:746
> +	   if (this.views[this.views.current] === "Containment") {

Are you comparing to localized strings?