[webkit-reviews] review denied: [Bug 54795] [Chromium] Autocomplete suggestion extends out of window (and onto second monitor) : [Attachment 84381] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 54795: [Chromium] Autocomplete suggestion extends out of window (and onto
second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795

Attachment 84381: Patch
https://bugs.webkit.org/attachment.cgi?id=84381&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84381&action=review

> Source/WebCore/ChangeLog:10
> +	   Test:
manual-tests/autofill-popup-width-restrction-within-screen.html

This bug is reproducible for <select>, right?  If so, we had better remove the
word "autofill" from the file name.
If this bug is only for Chromium's autofill feature, the test should be in
WebCore/manual-tests/chromium/.

>
Source/WebCore/manual-tests/autofill-popup-width-restrction-within-screen.html:
26
> +   1, Launch Chrome and maximize the browser window size in the right
screen.<br>
> +   2, Enter a very long string into "Right to Left" text input box.<br>
> +   3, Hit enter.<br>
> +   5, Go back and start to enter the same string again.<br>
> +   6, Make sure the popup list box's width which suggests the result doesn't
exceed the right screen width.<br>

There is no step 4? :-)
Your HTML looks not good.
- Please use either of lowercase tag names or uppercase tag names consistently.

- Use <ol><li> for ordered lists.