[webkit-reviews] review granted: [Bug 48719] HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%) : [Attachment 84167] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 22:40:42 PST 2011


Eric Seidel <eric at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 48719: HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719

Attachment 84167: Patch
https://bugs.webkit.org/attachment.cgi?id=84167&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Despite Darin's long-ago, good advice. This is ridiculous.  I'm not gonna make
you post a 15th patch, or whatever we're up to.

I would however like you to go through and see if you can remove more of the
element to node replacements you did before landing (and correct the ChangeLog
as you noted you would).

I'm happy to look at another patch if you would like, but only if you'd like.

Thanks again for all your hard work on this.  I'm sorry it took so long, but
hopefully you feel good came out of it.  I certainly do. :)


More information about the webkit-reviews mailing list