[webkit-reviews] review denied: [Bug 54440] [Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction : [Attachment 84039] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 54440: [Refactoring] Make ScheduledEvent on FrameView abstract out to
ScheduleAction
https://bugs.webkit.org/show_bug.cgi?id=54440

Attachment 84039: Patch
https://bugs.webkit.org/attachment.cgi?id=84039&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84039&action=review

r- because of some minor issues.

> Source/WebCore/page/FrameActionScheduler.h:69
> +    void scheduleAction(ScheduledAction*);

We should add a comment about the ownership of the specified ScheduledAction
object.

> Source/WebCore/page/FrameView.cpp:126
> +    , m_scheduledActions(new FrameActionScheduler())

The name m_scheduledActions is not appropriate.  It should be m_actionScheduler
or something.