[webkit-reviews] review granted: [Bug 55503] Cleanup: Remove unnecessary "()" from function prototypes that take no arguments in build-webkit; And fix misspelled word. : [Attachment 84288] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 1 18:04:36 PST 2011
Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 55503: Cleanup: Remove unnecessary "()" from function prototypes that take
no arguments in build-webkit; And fix misspelled word.
https://bugs.webkit.org/show_bug.cgi?id=55503
Attachment 84288: Patch
https://bugs.webkit.org/attachment.cgi?id=84288&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84288&action=review
rs=me, assuming this is considered "good perl style".
> Tools/Scripts/build-webkit:44
> +sub checkForJavaSDK;
I guess this is good perl? Looks strange to a non-perl-er.
More information about the webkit-reviews
mailing list