[webkit-reviews] review requested: [Bug 55534] Clean up macros in Extensions3DOpenGL.cpp : [Attachment 84332] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 55534: Clean up macros in Extensions3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=55534

Attachment 84332: Patch
https://bugs.webkit.org/attachment.cgi?id=84332&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Change "#if GL_APPLE_vertex_array_object" macros to check that
GL_APPLE_vertex_array_object is both defined and non-zero.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
empty #else clause.
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
return check.  Remove #else clause that would never have
compiled (since array is not a WTF::String).
---
 2 files changed, 25 insertions(+), 7 deletions(-)