[webkit-reviews] review granted: [Bug 55530] V8 code generator doesn't properly support a single SerializedScriptValue attribute : [Attachment 84326] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 55530: V8 code generator doesn't properly support a single
SerializedScriptValue attribute
https://bugs.webkit.org/show_bug.cgi?id=55530

Attachment 84326: Patch
https://bugs.webkit.org/attachment.cgi?id=84326&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84326&action=review

look great.  thanks for adding the test.

i didn't look carefully at the non-v8 changes, assuming that most of those are
just churn from out-of-date golden files

>
Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl:15
> + * EXPRESS OR IMPLIED WARRANTIEstrArg, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED

A few extra characters snuck in here in the middle of "WARRANTIES"

>>
Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
29
>> +#include "wtf/text/StringHash.h"
> 
> wtf includes should be <wtf/file.h> instead of "wtf/file.h".	[build/include]
[4]

If you are feeling super ambitious you could probably fix this one easily as
well :)