[webkit-reviews] review granted: [Bug 55524] JavaScriptCore GYP build should copy some headers into the target framework : [Attachment 84321] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 16:42:15 PST 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 55524: JavaScriptCore GYP build should copy some headers into the target
framework
https://bugs.webkit.org/show_bug.cgi?id=55524

Attachment 84321: Patch
https://bugs.webkit.org/attachment.cgi?id=84321&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yeah, I'm not a big fan here.  Seems like we should have a separate (identical)
list of "private" and "public" headers in the gypi.  You could no longer
auto-gen this gypi list from the file system for example.

But I think these are also things we can make better decisions on as we get
further in this process.


More information about the webkit-reviews mailing list