[webkit-reviews] review denied: [Bug 55017] SVGImage causes MainResourceLoader leaks : [Attachment 83766] Update patch to fix assertion failures
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 1 16:16:34 PST 2011
Adam Barth <abarth at webkit.org> has denied Xianzhu Wang
<wangxianzhu at google.com>'s request for review:
Bug 55017: SVGImage causes MainResourceLoader leaks
https://bugs.webkit.org/show_bug.cgi?id=55017
Attachment 83766: Update patch to fix assertion failures
https://bugs.webkit.org/attachment.cgi?id=83766&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83766&action=review
> Source/WebCore/svg/graphics/SVGImage.cpp:279
> + if (!loader->activeDocumentLoader())
> + loader->init(); // Make sure the DocumentLoader is created
Why is there a branch here? This boot-up process should be deterministic.
More information about the webkit-reviews
mailing list