[webkit-reviews] review denied: [Bug 55512] EventQueue needs to be ref counted : [Attachment 84302] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 1 15:35:04 PST 2011
Mihai Parparita <mihaip at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 55512: EventQueue needs to be ref counted
https://bugs.webkit.org/show_bug.cgi?id=55512
Attachment 84302: Patch
https://bugs.webkit.org/attachment.cgi?id=84302&action=review
------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review
> Source/WebCore/dom/EventQueue.cpp:94
> + RefPtr<EventQueue> m_keepAliveDuringIteration = this;
RefPtr<EventQueue> protector(this) is a more common pattern for this:
https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium
Either way the name shouldn't start with m_ since it's not a member.
More information about the webkit-reviews
mailing list