[webkit-reviews] review granted: [Bug 42484] Support localized numbers in <input type=number> : [Attachment 84179] Patch 6

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 42484: Support localized numbers in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42484

Attachment 84179: Patch 6
https://bugs.webkit.org/attachment.cgi?id=84179&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84179&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:5665
> +		F5CC42DC12F801CA00D5F7E3 /* LocalizedNumberMac.mm in Sources */
= {isa = PBXBuildFile; fileRef = F5CC42DB12F801CA00D5F7E3 /*
LocalizedNumberMac.mm */; };

Did you run sort-Xcode-project-file after your changes? This file looks out of
order.

> Source/WebCore/platform/text/mac/LocalizedNumberMac.mm:58
> +    NSNumberFormatter* formatter = [[[NSNumberFormatter alloc] init]
autorelease];

I don't know how this stuff works. Can you check with ObJC-heads before
landing?