[webkit-reviews] review denied: [Bug 6503] content property doesn't support quotes : [Attachment 83029] Proposed Patch. Addressed DHyatt's concerns.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied  review:
Bug 6503: content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503

Attachment 83029: Proposed Patch. Addressed DHyatt's concerns.
https://bugs.webkit.org/attachment.cgi?id=83029&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Two gotchas:

(1) You need to patch RenderStyle::diff for when quotes change dynamically to
supply the appropriate hint (layout hint I think).
(2) It seems like:

&& *quotes.get() == *o.quotes.get()

will crash if you are comparing against objects with quotes:none, since you'll
deref 0.