[webkit-reviews] review granted: [Bug 55487] Expand ruby text when it is shorter than the ruby base : [Attachment 84259] Expand ruby text with default text-align when it is shorter than the ruby base

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 11:41:14 PST 2011


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 55487: Expand ruby text when it is shorter than the ruby base
https://bugs.webkit.org/show_bug.cgi?id=55487

Attachment 84259: Expand ruby text with default text-align when it is shorter
than the ruby base
https://bugs.webkit.org/attachment.cgi?id=84259&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84259&action=review

> Source/WebCore/rendering/RenderRubyText.cpp:59
> +    ETextAlign textAlign = style()->textAlign();
> +    if (textAlign != TAAUTO)
> +	   return RenderBlock::textAlignmentForLine(endsWithSoftBreak);
> +
> +    return JUSTIFY;

Might be nice to have a why comment here.


More information about the webkit-reviews mailing list