[webkit-reviews] review granted: [Bug 55483] WebKit2 needs to be made localizable : [Attachment 84256] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 11:22:38 PST 2011


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 55483: WebKit2 needs to be made localizable
https://bugs.webkit.org/show_bug.cgi?id=55483

Attachment 84256: Patch
https://bugs.webkit.org/attachment.cgi?id=84256&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84256&action=review

> Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm:70
> +    RetainPtr<CFStringRef> cfLocalization(AdoptCF,
CFStringCreateWithCharacters(0, reinterpret_cast<const
UniChar*>(localization.characters()), localization.length()));

Can't you just use String::createCFString here?


More information about the webkit-reviews mailing list