[webkit-reviews] review granted: [Bug 54926] All Console Messages should be passed to ChromeClients. : [Attachment 83676] [PATCH] Addressed Comments

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 54926: All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926

Attachment 83676: [PATCH] Addressed Comments
https://bugs.webkit.org/attachment.cgi?id=83676&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83676&action=review

r+ if you add the Web prefix to the strings.

> Source/WebKit/mac/WebView/WebUIDelegatePrivate.h:119
> +extern NSString *ConsoleMessageHTMLMessageSource;
> +extern NSString *ConsoleMessageWMLMessageSource;
> +extern NSString *ConsoleMessageXMLMessageSource;
> +extern NSString *ConsoleMessageJSMessageSource;
> +extern NSString *ConsoleMessageCSSMessageSource;
> +extern NSString *ConsoleMessageOtherMessageSource;
> +
> +// Message Types.
> +extern NSString *ConsoleMessageLogMessageType;
> +extern NSString *ConsoleMessageObjectMessageType;
> +extern NSString *ConsoleMessageTraceMessageType;
> +extern NSString *ConsoleMessageStartGroupMessageType;
> +extern NSString *ConsoleMessageStartGroupCollapsedMessageType;
> +extern NSString *ConsoleMessageEndGroupMessageType;
> +extern NSString *ConsoleMessageAssertMessageType;
> +extern NSString *ConsoleMessageUncaughtExceptionMessageType;
> +extern NSString *ConsoleMessageNetworkErrorMessageType;
> +
> +// Message Levels.
> +extern NSString *ConsoleMessageTipMessageLevel;
> +extern NSString *ConsoleMessageLogMessageLevel;
> +extern NSString *ConsoleMessageWarningMessageLevel;
> +extern NSString *ConsoleMessageErrorMessageLevel;
> +extern NSString *ConsoleMessageDebugMessageLevel;

Sorry I didn't catch this earlier, but these need a "Web" prefix.