[webkit-reviews] review granted: [Bug 55353] wrap json in a function call to afford cross-domain loading : [Attachment 84185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 10:08:16 PST 2011


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 55353: wrap json in a function call to afford cross-domain loading
https://bugs.webkit.org/show_bug.cgi?id=55353

Attachment 84185: Patch
https://bugs.webkit.org/attachment.cgi?id=84185&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84185&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:46

> +JSON_PREFIX = "ADD_RESULTS("
> +JSON_SUFFIX = ");"

Nit: Maybe prefix these with _ to mark them module private?


More information about the webkit-reviews mailing list