[webkit-reviews] review granted: [Bug 54811] REGRESSION(r78383): Failure to connect on websocketstest.com : [Attachment 84183] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yuta Kitamura <yutak at chromium.org>'s
request for review:
Bug 54811: REGRESSION(r78383): Failure to connect on websocketstest.com
https://bugs.webkit.org/show_bug.cgi?id=54811

Attachment 84183: Patch
https://bugs.webkit.org/attachment.cgi?id=84183&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84183&action=review

I’m going to say r=me, but I’d prefer that the function name be changed.

> Source/WebCore/platform/network/cf/SocketStreamHandle.h:75
> +    unsigned short getPort() const;

WebKit style naming for these functions does not include the word “get” -- this
is mentioned in the Names section of
<http://www.webkit.org/coding/coding-style.html>.

This function should just be named port. The patch is otherwise fine.