[webkit-reviews] review granted: [Bug 53146] [GTK] Combo boxes should emit object:selection-changed even when collapsed : [Attachment 83786] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 53146: [GTK] Combo boxes should emit object:selection-changed even when
collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

Attachment 83786: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=83786&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83786&action=review

Please unskip tests that were previously crashing with this commit.

>
LayoutTests/platform/gtk/accessibility/combo-box-collapsed-selection-changed.ht
ml:26
> +  description("This tests that the 'state-changed:selected' signal is
emitted when arrowing through the options of a combobox while collapsed.");
> +
> +  if (window.layoutTestController) {
> +    layoutTestController.dumpAsText();
> +  }
> +
> +  if (window.accessibilityController) {
> +    accessibilityController.logAccessibilityEvents();
> +  }
> +
> +  // Focus in the combobox and move around the options. The signal
> +  // 'state-change:selected' should be emitted with every change.
> +  document.getElementById("combo").focus();
> +  eventSender.keyDown("downArrow");
> +  eventSender.keyDown("downArrow");
> +  eventSender.keyDown("upArrow");
> +  eventSender.keyDown("upArrow");

Please switch this to four space indent.

> Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:106
> +    // Ensure the current list object is the same than the old one so
> +    // further comparisons make sense. Otherwise, just reset
> +    // oldFocusedObject so it won't be taken into account.
> +    if (oldListObject != listObject)
>	   oldFocusedObject = 0;

This approach is incorrect for dealing with multiple views, I think, but that's
a bigger problem that should be addressed in some other patch. There's probably
a better way to handle focus changes than caching only one oldFocusedObject
statically.