[webkit-reviews] review granted: [Bug 55444] [Web Timing] Handle the case where no responseEnd time is available. : [Attachment 84182] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 55444: [Web Timing] Handle the case where no responseEnd time is available.
https://bugs.webkit.org/show_bug.cgi?id=55444

Attachment 84182: Patch
https://bugs.webkit.org/attachment.cgi?id=84182&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84182&action=review

Too bad there isn't a good way to test this. :(

> LayoutTests/platform/chromium/test_expectations.txt:-1558
> -BUGCR18116 MAC LINUX : fast/dom/prototype-inheritance-2.html = TEXT CRASH

Are you sure about these?

> Source/WebCore/loader/MainResourceLoader.cpp:62
> +    , m_timeOfLastDataReceived(0.0)

Gah! Good catch.