[webkit-reviews] review canceled: [Bug 55368] Fix alignment warnings in ARMv7 : [Attachment 84048] alignment.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 05:39:06 PST 2011


Xan Lopez <xan.lopez at gmail.com> has canceled Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 55368: Fix alignment warnings in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55368

Attachment 84048: alignment.diff
https://bugs.webkit.org/attachment.cgi?id=84048&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, this fails in a few places in debug builds because there's an ASSERT
checking the correctness of the cast that uses __alignof__, which needs the
size of the class, which is not available in many places (since we forward
declare instead of including the header). I'll see if I can either fix it for
good or at least attach a patch with the easy fixes.


More information about the webkit-reviews mailing list