[webkit-reviews] review granted: [Bug 54522] Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour : [Attachment 82580] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 1 00:43:44 PST 2011
Adam Barth <abarth at webkit.org> has granted review:
Bug 54522: Fix platform/image-encoders/JPEGImageEncoder.cpp
empty_output_buffer() behaviour
https://bugs.webkit.org/show_bug.cgi?id=54522
Attachment 82580: Patch
https://bugs.webkit.org/attachment.cgi?id=82580&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I think this patch is fine, but I'm not sure excited about it. The problem
with fixing dead code is that we can't test the change, which means we're
likely to regress.
We'll need to explain why we can't test this change (and remove the "no new
tests" OOPS) before landing.
More information about the webkit-reviews
mailing list