[webkit-reviews] review denied: [Bug 54795] [Chromium] Autocomplete suggestion extends out of window (and onto second monitor) : [Attachment 84189] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 54795: [Chromium] Autocomplete suggestion extends out of window (and onto
second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795

Attachment 84189: Patch
https://bugs.webkit.org/attachment.cgi?id=84189&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84189&action=review

>> Source/WebCore/ChangeLog:10
>> +	    Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and
canvas/philip/tests/2d.composite.globalAlpha.fill.html with
--accelerated-2d-canvas. With multiple screens and submit long input string
first. And check the popup window size after that.

ChangeLog is not a place to write a test procedure of the change.  I think we
need to introduce new manual test, and should write the test procedure in it.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:389
> +		   int x = widgetRect.x();
> +		   int w = widgetRect.width();
>		   widgetRect = chromeClient->windowToScreen(frameRect());
> +		   widgetRect.setX(x);
> +		   widgetRect.setWidth(w);

This code doesn't look straightforward.
How about:

IntRect frameInScreen = chromeClient->windowToScreen(frameRect());
widgetRect.setY(frameInScreen.y());
widgetRect.setHeight(frameInScreen.height());