[webkit-reviews] review granted: [Bug 63777] location.replace with a hash change does not update the history entry : [Attachment 99426] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 63777: location.replace with a hash change does not update the history
entry
https://bugs.webkit.org/show_bug.cgi?id=63777

Attachment 99426: Patch
https://bugs.webkit.org/attachment.cgi?id=99426&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99426&action=review

R=me

> Source/WebCore/loader/HistoryController.cpp:514
> +    if (m_currentItem) {

I notice that recursiveUpdateForSameDocumentNavigation() can assign
m_currentItem if
there is a non-null m_provisionalItem.	I just want to make sure that it makes
sense
to work with m_currentItem after calling
recursiveUpdateForSameDocumentNavigation()
versus before.