[webkit-reviews] review requested: [Bug 63235] [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test : [Attachment 99400] Specified baseUrl to be a local file as we must get a security origin with granted permission to request local resources.

[bugzilla-daemon at webkit.org]

Rafael Brandao <rafael.lobo at openbossa.org> has asked  for review:
Bug 63235: [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Attachment 99400: Specified baseUrl to be a local file as we must get a
security origin with granted permission to request local resources.
https://bugs.webkit.org/attachment.cgi?id=99400&action=review

------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
Also added the expected behavior for the opposite situation. I've removed
QSignalSpy because it would always increment its counter, no matter what
happens related to the local resources, so it looks like it was pointless to
check it there.

I've also added a comment to the test setHtmlWithBaseURL to explain the
difference between this test and the other one. Perhaps we should rename them?
Or is this unrelated to this patch and I should remove it? I don't know, I
think it's nice to explain why they are different and what they're actually
testing.

We've discussed the use of baseUrl to fix those tests at
https://bugs.webkit.org/show_bug.cgi?id=63236. To make it short, it looks like
we've been using setHtml in the wrong way.

Feedbacks are welcome! :)