[webkit-reviews] review granted: [Bug 63681] Chromium bug: Compositing on a lost context causes latch deadlocks : [Attachment 99382] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted John Bates
<jbates at google.com>'s request for review:
Bug 63681: Chromium bug: Compositing on a lost context causes latch deadlocks
https://bugs.webkit.org/show_bug.cgi?id=63681

Attachment 99382: Patch
https://bugs.webkit.org/attachment.cgi?id=99382&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99382&action=review

> Source/WebKit/chromium/ChangeLog:9
> +	   The cause of deadlock was that a setLatch command is added to the
lost
> +	   compositor GL context, and a waitLatch would never complete on a
child context.
> +	   This change checks whether the compositor context is in error state
before
> +	   doing the compositing.

nit: in the future, put this after the bug link and a newline.	pattern is:

Reviewed by ...
<newline>
bug title
bug URL
<newline>
long desc
long desc
long desc
<newline>
per-file stuff