[webkit-reviews] review granted: [Bug 63678] More ScrollableArea scaffolding : [Attachment 99352] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 63678: More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

Attachment 99352: Patch
https://bugs.webkit.org/attachment.cgi?id=99352&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=99352&action=review

> Source/WebCore/platform/ScrollableArea.cpp:208
> +bool ScrollableArea::isPinnedInDirectionOfScrollDelta(const IntSize&
scrollDelta) const

You can drop “OfScrollDelta” from the name.

> Source/WebCore/platform/chromium/FramelessScrollView.cpp:62
> +    // FIXME

Can you elaborate?

> Source/WebCore/rendering/RenderLayer.cpp:797
> +    RenderObject* nextRenderer = renderer()->parent();
> +
> +    while (nextRenderer) {
> +	   if (nextRenderer->isBox() &&
toRenderBox(nextRenderer)->canBeScrolledAndHasScrollableArea())
> +	       return nextRenderer->enclosingLayer();
> +
> +	   nextRenderer = nextRenderer->parent();
> +    }
> +
> +    return 0;

Looks like a for() loop.

> Source/WebCore/rendering/RenderLayer.cpp:2002
> +    // FIXME: We should return the frame view here (or possibly a parent
frame view,

s/parent/ancestor/?

> Source/WebKit/chromium/src/WebScrollbarImpl.cpp:295
> +    // FIXME

More detail?