[webkit-reviews] review granted: [Bug 62459] Local files cannot load icons. : [Attachment 98823] Removing temporary variable and changing variable's name from pageURL to documentURL

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 62459: Local files cannot load icons.
https://bugs.webkit.org/show_bug.cgi?id=62459

Attachment 98823: Removing temporary variable and changing variable's name from
pageURL to documentURL
https://bugs.webkit.org/attachment.cgi?id=98823&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98823&action=review

> Source/WebCore/loader/icon/IconDatabase.h:141
> +    static bool pageCanHaveIcon(const String& documentURL)

Why is this called "pageCanHaveIcon" when it takes a documentURL?  Maybe it
should be called documentCanHaveIcon?  Also, why is this function inline?  It
probably should be out-of-line.