[webkit-reviews] review granted: [Bug 63465] Links to crash logs on TestFailures page should include the crashing symbol (like links in results.html do) : [Attachment 99304] Include the crashing symbol in crash logs links on TestFailures

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 63465: Links to crash logs on TestFailures page should include the crashing
symbol (like links in results.html do)
https://bugs.webkit.org/show_bug.cgi?id=63465

Attachment 99304: Include the crashing symbol in crash logs links on
TestFailures
https://bugs.webkit.org/attachment.cgi?id=99304&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99304&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Layout
TestResultsLoader.js:36
>	       if (cachedData.version === currentCachedDataVersion) {

Shouldn't this be (cachedData.version >= 1)?  Or do you only want to use the
cached version if it's up-to-date?

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Layout
TestResultsLoader.js:76
> +			       result.crashingSymbol = match[1];

You don't want to break out of the for loop here when you get a match?	Or do
you want the last symbol to "win"?